RubyParser translation for stabby lambdas with it
#3616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
This one causes it, can't tell why though prism/test/prism/ruby/ruby_parser_test.rb Lines 18 to 24 in 3e8066e Overall it would still be parsed as 3.3 since there is no released version of |
Contributor
Author
|
AHHH thank you @Earlopain! Prism should not do this, because there is code in RubyParser where it is comparing a Sexp with a line/file to a fresh Sexp with no line/file and changing its behavior as a result (example). Updated this PR to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3409
However, I'm a little confused and I may be missing something.
The tests pass (as you can see) and the expected output in Prism's test is:
However, when I run RubyParser myself, I get
I honestly can't explain the discrepancy. 😕